Support for scala 2.13.0-M5 #2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test FAILed. |
raboof
force-pushed
the
scala-2.13.0-M5
branch
from
c35f898 to
d534d3b
Compare
akka-ci
added
validating
|
Test FAILed. |
jrudolph
reviewed
Nov 29, 2018
akka-http-core/src/main/scala-2.13.0-M5/akka/http/ccompat/package.scala
Outdated
Show resolved
Hide resolved
Is that documented somewhere? Would be nice if no overload was necessary at all and the compiler would just accept a Seq in the first place even without the We could also say that we don't keep source compatibility and remove the |
akka-ci
added
validating
|
Test FAILed. |
|
@jrudolph do you think we should only support the varargs variant for 2.13 and deprecate the |
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test FAILed. |
akka-ci
added
validating
|
Test PASSed. |
akka-ci
added
validating
|
Test PASSed. |
akka-ci
added
validating
|
Test PASSed. |
jrudolph
force-pushed
the
scala-2.13.0-M5
branch
from
5c78251 to
75abac5
Compare
akka-ci
added
validating
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated just akka-http-core on 2.12/2.13 for now.
Unfortunately we have a number of places where we have both a
varargsand aimmutable.Seqoverload for the same method. This is no longer valid on 2.13.0, and the only way I could think of to solve this in a binary compatible way was a rather weird trick: introduce aVASeqtype which corresponds toimmutable.Seqon 2.12 andimmutable.Iterableon 2.13 (to avoid the ambiguity but at the same time be mostly source-compatible and keep intact the fact that this value is immutable).